Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Feature: Allow 'execute program' (^) as a task in in rulesets #81

Merged
merged 5 commits into from Jun 20, 2018
Merged

Conversation

itbane
Copy link
Contributor

@itbane itbane commented May 17, 2018

Pull Request (PR) description

This PR adds a new task to the rulesets which allows the usage of the 'execute program' feature.

This Pull Request (PR) fixes the following issues

Fixes #80

@bastelfreak
Copy link
Member

Hi @itbane, thanks for the PR. One travis job failed, I restarted it. Can you please take a look at the used email address in your commits? It isn't associated with your github account.

@bastelfreak bastelfreak added the enhancement New feature or request label May 20, 2018
@bastelfreak bastelfreak added the needs-work not ready to merge just yet label May 20, 2018
Copy link
Member

@dhollinger dhollinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@itbane Thanks for the PR. New unit and acceptance tests are needed for the new feature before the PR can be approved. We can help you with this if you need it.

@itbane
Copy link
Contributor Author

itbane commented Jun 20, 2018

Hi, sorry, been a while. After getting rspec working locally (first time for everything...), I've added an unit test for the new feature. Is this enough or is anything else missing? As I've never worked with Travis before, there sometime seem to be errors building the test environment itself (e.g. this) - are these common and what should I, as a contributor, do about them?

@dhollinger dhollinger removed needs-tests needs-work not ready to merge just yet labels Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants