default policy management is now optional #184
Conversation
|
What is the use-case for this? |
|
I don't want to manage default admin/api policy with an hash conf. I need to manage it with a custom erb template |
|
It looks like we have a couple of undocumented parameters. $api_template = $rundeck::params::api_template,
$acl_template = $rundeck::params::acl_template,Does this suit your needs? |
|
These parameters seem unused. Template file path is hardcoded |
|
Huh. Could this PR be to actually make those do something, then? Good catch. |
| group => $group, | ||
| properties_dir => $properties_dir, | ||
| } | ||
| if($manage_default_policy == true){ |
There was a problem hiding this comment.
This could just be:
if $manage_default_policy {
bovy89
force-pushed
the
feature/manage_default_policy
branch
from
32fbaec
to
cef6d04
Compare
bovy89
force-pushed
the
feature/manage_default_policy
branch
from
cef6d04
to
17cb814
Compare
default policy management is now optional
|
@jyaworski Can you release a new version of this module asap? Thanks |
|
@bovy89 why the rush? @liamjbennett I believe we just released a new module a short time ago. Should this go in anyway? |
|
I just wanted to know if was possible a new release of this module in a couple of days; otherwhise I need to include my feature in another way |
No description provided.