Multiple auth users #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 21, 2015 20:44
* previously this only seemed to work with a single user and realm.properties was broken * works now with an array of auth_users, instead of with only just one single user * fixes a linebreaking issue in realm.properties * fixes a trailing comma issue in realm.properties
* only apply roles rendering logic in realm.properties.erb if roles are given
Just in case anyone's ever used it with just a single user
|
This is a great PR. Thanks for taking to time to contribute with tests - that's much appreciated. |
bastelfreak
pushed a commit
to bastelfreak/puppet-rundeck
that referenced
this pull request
Jan 13, 2017
…tent docs (default_content) align rdoc and readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was not possible to create a realm.properties with more than the admin user. Only the admin user would be created with a valid syntax.
This pull request adds support for an array of users. Roles don't have to be provided as they're optional. Furthermore, the order of a user's properties is not relevant anymore. A line breaking issue and a comma issue have also been fixed.
Everything comes with tests :)