OptionParser::InvalidOption ERROR when using --no-rdoc (this is not a warning)

[nicocesar]

https://github.com/maestrodev/puppet-rvm/blob/967c58ce8bbfc3d92dbfe1b29e4a7a5fceee942f/lib/puppet/provider/rvm_gem/gem.rb#L112

--no-rdoc and --no-ri was deprecated in 2011:
rubygems/rubygems@0d22d60

Notice: /Stage[main]/Rvm/Rvm_system_ruby[ruby-2.3.5]/default_use: default_use changed 'false' to 'true'
Could not update: Execution of '/usr/local/rvm/bin/rvm ruby-2.3.5 do gem install -v 0.1.13 --no-rdoc --no-ri jwt' returned 1: ERROR:  While executing gem ... (OptionParser::InvalidOption)

issue #40 proposes a solution with sources, but currently --no-rdoc option will fail to install

[nmagedman]

As @nicocesar said, gem install --no-rdoc has been deprecated for ages.
gem 3.0 (distributed with ruby 2.6) finally dropped support for it, causing deploys to hard fail.

I attempted to PR a fix in #147, however this repo seems to have been abandoned. The last commit was in 2017. The Travis-CI setup is so outdated that all builds fail. (I submitted an empty PR, #148, to confirm that even master fails.)

WORKAROUND
As a total Kludge, we can make things work for now by specifying a source option to rvm_gem, e.g.:

  rvm_gem { 'erubis':
    ruby_version => "ruby-${ruby_version}",
    require      => Rvm_system_ruby[$ruby_version],
    source       => "https://rubygems.org/",
  }

By total happenstance, if you specify a rubygems source option to rvm_gem, it bypasses the codepath that adds the --no-rdoc command-line option to gem install.
See lib/puppet/provider/rvm_gem/gem.rb:

 91     if source = resource[:source]
          …
109         command << "--source" << "#{source}" << resource[:name]
          …
111     else
112       command << "--no-rdoc" << "--no-ri" <<  resource[:name]
113     end

[ekohl]

Addressed in 4382114