BREAKING: Remove restorecond management support #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oranenj
force-pushed
the
remove_restorecond
branch
from
d467a58
to
c105139
Compare
vinzent
approved these changes
Mar 29, 2017
There was a problem hiding this comment.
I'd personally do not use restorecond and do not know people which use is (with or without puppet). Back in EL5 days I know some folks using it.
IMHO with RHEL7 the restorecond was moved to the optional channel which means its available but there is no suport.
I'm fine with removing this restorecond interface.
vinzent
changed the title
oranenj
force-pushed
the
remove_restorecond
branch
from
c105139
to
3d239f6
Compare
|
Rebased to fix the documentation merge conflict |
I don't think this is even used on modern systems, and the value of the manifest is dubious. Does the default config even make sense?
oranenj
force-pushed
the
remove_restorecond
branch
from
3d239f6
to
01a0649
Compare
|
Rebased again after lint fixes... |
EmRowlands
pushed a commit
to EmRowlands/puppet-selinux
that referenced
this pull request
Mar 29, 2023
BREAKING: Remove restorecond management support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think this is even used on modern systems, and the value of the
manifest is dubious. Does the default config even make sense?
For 1.0.0, I think the support should be removed and reintegrated later if it's wanted, so here's a pull request that gets rid of it.