use systemd for debian 9 snmpd options #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Feb 24, 2020
|
Can you take a look at the failing spec tests? |
|
Well I don't understand the error :
so I need your help, you can propose anything on rspec I'll merge |
|
master isn't passing test either so maybe you should fix master first ? |
|
any news on this ? |
vchepkov
reviewed
Mar 31, 2020
@hdep https://travis-ci.org/github/voxpupuli/puppet-snmp/jobs/654856422#L1640 It looks that during the manifest is applied a second time it tries to restart the service, probably because it was not started the first time or failed to start |
alexjfisher
reviewed
Apr 1, 2020
|
thanks for your help all. Now tests are okay. |
bastelfreak
approved these changes
Apr 5, 2020
|
Hi @bastelfreak, any chance to get this merge soon ? Best regards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Debian 9 use systemd
This Pull Request (PR) fixes the following issues
Fixes #110