split out forwarder and server into separate classes #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
We have a very weird issue with this class. We are on Linux and are ONLY trying to install the Splunk forwarder, not the main server. It turns out, however, that it has been trying to also instantiate the main server classes. We were getting an error on the license_splunk exec that the splunk command was not found.
@gregswift and I have been banging our heads on this for a couple days, and found out that it works if the two execs for the main Splunk server were removed from the path.
This would seem to indicate that somehow it is realizing wildcard services in a way that is inconsistent with how it is being called. We scrutinized our code and the code in this module, and can not find any code path that should be realizing these services.
We see this issue on Puppet 3. On our Puppet 2 standup (which is on its way out), it works as expected. We have not tried Puppet 4.
Obviously we're open to a better way to do this. Or it may be a bug in this module or in Puppet itself. We're just submitting this PR to give a heads up on the problem and to see if anyone else has hit it or has another idea for a solution.
Thank you!