Release v0.1.0 #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
requested changes
Nov 12, 2017
README.md
Outdated
| @@ -27,7 +27,7 @@ The stackify module requires the following: | |||
| * Puppet Agent 4.0 or later. | |||
There was a problem hiding this comment.
can you bump this to 4.7.1? This is the lowest version that Vox Pupuli supports.
metadata.json
Outdated
| "issues_url": "https://github.com/tragiccode/tragiccode-stackify/issues", | ||
| "source": "https://github.com/voxpupuli/puppet-stackify", | ||
| "project_page": "https://github.com/voxpupuli/puppet-stackify", | ||
| "issues_url": "https://github.com/voxpupuli/puppet-stackify/issues", | ||
| "dependencies": [ | ||
| {"name":"puppetlabs-stdlib","version_requirement":">= 4.0.0 < 5.0.0"} |
There was a problem hiding this comment.
please bump stdlib to 4.13.1
metadata.json
Outdated
| "requirements": [ | ||
| { | ||
| "name": "puppet", | ||
| "version_requirement": ">= 4.0.0 < 6.0.0" |
There was a problem hiding this comment.
please bump puppet to 4.7.1
metadata.json
Outdated
| "name": "puppet", | ||
| "version_requirement": ">= 4.0.0 < 6.0.0" | ||
| } | ||
| ], | ||
| "data_provider": null |
There was a problem hiding this comment.
I am not sure if data_provider is still valid? It may got deprecated.
There was a problem hiding this comment.
Removed and Done.
|
@bastelfreak Everything should be good to go now. Resolved all the issues you had raised. |
bastelfreak
approved these changes
Nov 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bastelfreak, Not really sure how the changelog should be for the initial release. Let me know if i need to make any changes.