allow Sensitive type for content param #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphink
reviewed
Jul 15, 2019
| Systemd::Dropin $filename = $name, | ||
| Enum['present', 'absent', 'file'] $ensure = 'present', | ||
| Stdlib::Absolutepath $path = '/etc/systemd/system', | ||
| Optional[Variant[String,Sensitive[String]]] $content = undef, |
There was a problem hiding this comment.
It might be clearer to make that a Variant[String,Sensitive[String],Undef]
There was a problem hiding this comment.
@raphink hm IMHO Optional is the more idomatic way. Also grepping over a couple of modules i have checked out here from various sources it seems Optional[Variant] is what is usually used:
$ find . -name "*.pp" |xargs grep -E "Variant.*Undef" | wc -l
40
$ find . -name "*.pp" |xargs grep -E "Optional\[Variant" | wc -l
492
There was a problem hiding this comment.
I go with @TheMeier here. The default should be undef and that requires the type to be Optional
There was a problem hiding this comment.
@bastelfreak technically it doesn't require to use Optional, as a variant allowing Undef works as well.
|
I think it should be |
simondeziel
pushed a commit
to simondeziel/puppet-systemd
that referenced
this pull request
Jun 16, 2021
simondeziel
pushed a commit
to simondeziel/puppet-systemd
that referenced
this pull request
Jun 16, 2021
op-ct
pushed a commit
to op-ct/puppet-systemd
that referenced
this pull request
Jun 17, 2022
modulesync 2.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #114