Adds control group limits to ServiceLimits #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Systemd::ServiceLimits Data Type has been enhanced with the set of Control Group limits available to Systemd. Closes voxpupuli#35
EmilienM
approved these changes
Jul 20, 2017
|
@trevor-vaughan thanks, looks good to me. |
ekohl
reviewed
Jul 20, 2017
Gemfile
Outdated
| @@ -35,7 +35,7 @@ end | |||
| if facterversion = ENV['FACTER_GEM_VERSION'] | |||
| gem 'facter', facterversion, :require => false | |||
| else | |||
| gem 'facter', :require => false | |||
| gem 'facter', '~> 2.4.0', :require => false | |||
There was a problem hiding this comment.
Generally I like a note why it's pinned. I'm pretty sure that in this case it's because the facterdb has no facts for 2.5 yet, but when going over it you either want a note in git blame or a comment in the file.
|
@ekohl Reason 4,325 not to do things at midnight |
ekohl
reviewed
Jul 20, 2017
Gemfile
Outdated
| @@ -35,7 +35,8 @@ end | |||
| if facterversion = ENV['FACTER_GEM_VERSION'] | |||
| gem 'facter', facterversion, :require => false | |||
| else | |||
| gem 'facter', :require => false | |||
| # There are no facts in place for beaker > 2.4 in rspec-puppet-facts yet | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Systemd::ServiceLimits Data Type has been enhanced with the set of
Control Group limits available to Systemd.
Closes #35