Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR#18 broke service limits capacity #35

Closed
EmilienM opened this issue Jul 20, 2017 · 8 comments · Fixed by #36
Closed

PR#18 broke service limits capacity #35

EmilienM opened this issue Jul 20, 2017 · 8 comments · Fixed by #36
Assignees
@EmilienM

Comments

@EmilienM
Copy link

If you were using MemoryLimit feature in systemd, your Puppet catalog will broke because of #18.
@EmilienM
Copy link
Author

Workaround for OpenStack TripleO CI: https://review.rdoproject.org/r/#/c/7759/

@EmilienM
Copy link
Author

@bastelfreak ping hey it's me again

@trevor-vaughan
Copy link
Contributor

Working on adding the remainder of the limits in http://www.dsm.fordham.edu/cgi-bin/man-cgi.pl?topic=systemd.resource-control&ampsect=5. PR soon.

apevec pushed a commit to redhat-openstack/rdoinfo that referenced this issue Jul 20, 2017
@EmilienM
Pin puppet-systemd
713e72e 
Context:
voxpupuli/puppet-systemd#35

Note: 2 breakages in less than a week we'll probably have to make some
work on our promotion pipeline for Puppet modules. Also we need to be
cautious about this module, sounds like it breaks quite often lately.

Let's pin it to a recent / working commit so we can make progress.

Change-Id: I16a41db7f167b7224ccb54a07e0ce39d0bf527ca
trevor-vaughan added a commit to trevor-vaughan/puppet-systemd that referenced this issue Jul 20, 2017
@trevor-vaughan
Adds control group limits to ServiceLimits
cf85d03 
The Systemd::ServiceLimits Data Type has been enhanced with the set of
Control Group limits available to Systemd.

Closes voxpupuli#35
@trevor-vaughan trevor-vaughan mentioned this issue Jul 20, 2017
Merged
@trevor-vaughan
Copy link
Contributor

If someone could check the referenced PR, it would be appreciated.

rdoproject pushed a commit to rdo-packages/puppet-systemd-distgit that referenced this issue Jul 20, 2017
@EmilienM
Dummy commit to build a new version rpm
d12e0cb 
See https://review.rdoproject.org/r/7759 for context, and
voxpupuli/puppet-systemd#35.

Change-Id: Ic4f14b158707879db4fdabb88eb059651359e599
Depends-On: I16a41db7f167b7224ccb54a07e0ce39d0bf527ca
@trevor-vaughan
Copy link
Contributor

trevor-vaughan commented Jul 20, 2017 •
edited
Loading

@EmilienM Can you see if #36 fixes your issue?

@EmilienM
Copy link
Author

@trevor-vaughan it does.

@bastelfreak
Copy link
Member

@EmilienM can you provide tests for the openstack usecases?

@trevor-vaughan
Copy link
Contributor

@bastelfreak That should go into a different ticket. We covered the one item that was removed in this one.

trevor-vaughan added a commit that referenced this issue Jul 20, 2017
@trevor-vaughan
Adds control group limits to ServiceLimits (#36)
047b31d 
The Systemd::ServiceLimits Data Type has been enhanced with the set of
Control Group limits available to Systemd.

Closes #35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EmilienM EmilienM

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds control group limits to ServiceLimits trevor-vaughan/puppet-systemd
3 participants
@bastelfreak @EmilienM @trevor-vaughan