Remove dependency cycle when skip_roothints_download is true #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The requires for download-roothints and the hints file are set up earlier in the file conditional on $skip_roothints_download specifying it again here causes a dependency cycle.
|
This change looks good since the resource relationships are captured in the conditional above. The tests are failing though due to an extra whitespace now that the parameter is removed. Would you mind correcting that please? |
|
Excellent, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The requires for download-roothints and the hints file are set up earlier in
the file conditional on $skip_roothints_download specifying it again here
causes a dependency cycle.