Add service control and package ensure parameters

[cohoe]

This PR adds parameters for $service_enable and $service_ensure to the module. There are cases where I need the ability to stop/disable unbound.

Update: also adds parameter for $package_ensure to enable the ability to pin a specific version (default is installed aka present which maintains compatibility.

The Enum[] for service_ensure was lifted from puppetlabs-ntp. Per the Puppet Docs (4.6 to latest) this should be able to accept values of stopped, running, false, or true. However the Enum Data Type can only match strings, thus rendering the boolean values unavailable. Given the Puppetlabs reference module has this behavior as well, I suspect this will not be a problem for the majority of users who elect to use this parameter here.

[cohoe]

Tests failed due to what I believe are unrelated OpenBSD configurations.

  1) unbound on openbsd-5.9-amd64 with default params should contain Package[unbound]
     Failure/Error: it { is_expected.to contain_package(package) }
       expected that the catalogue would contain Package[unbound]

Package name is set to emptystring which prevents the package{} resource from being declared in the catalog.

2) unbound on openbsd-5.9-amd64 with default params should contain Concat::Fragment[unbound-header] with content =~ /\s+root-hints:\s"\/var\/unbound\/etc\/root.hints"/, content =~ ........
     Failure/Error:
       is_expected.to contain_concat__fragment(
         'unbound-header'
       ).with_content(........
       expected that the catalogue would contain Concat::Fragment[unbound-header] with content set to /\s+pidfile:\s"\/var\/run\/unbound\/unbound.pid"/ but it is set to "# Managed by Puppet\n#......

pidfile is set to /var/run/unbound.pid in hiera but /var/run/unbound/unbound.pid in test. I do not operate any OpenBSD systems so I do not know which one is appropriate.

[zachfi]

Thank you for the PR. I can take a look at the OpenBSD issue over the weekend and come back to this.

[zachfi]

I started testing here, corrected the pid path, but the package is now in my way. I just need a quick solution in the tests to skip the package test on openbsd and this will be looking good.

[zachfi]

I've corrected the OpenBSD tests. Thank you for the PR.