Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modulesync 4.0.0 #14

Merged
merged 2 commits into from
Nov 25, 2020
Merged

modulesync 4.0.0 #14

merged 2 commits into from
Nov 25, 2020

Conversation

bastelfreak
Copy link
Member

modulesync 4.0.0

ekohl
ekohl requested changes Nov 25, 2020
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No Puppet requirement found

.rubocop.yml Show resolved Hide resolved
ekohl and others added 2 commits November 25, 2020 22:34
@ekohl
Declare Puppet version compatibility
bacbfdd 
This allows our testing matrix to verify the support. This is a good
practice. Puppet may change its API's and then you have no idea if it
actually works.
@bastelfreak @ekohl
modulesync 4.0.0
d62907b
ekohl
ekohl approved these changes Nov 25, 2020
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 if it passes, but I also made some changes. Wondering if that deserves its own PR for the changelog.

@bastelfreak
Copy link
Member Author

created #15 which mentions the puppet version range

@bastelfreak bastelfreak merged commit a91acc8 into master Nov 25, 2020
@bastelfreak bastelfreak deleted the modulesync branch November 25, 2020 21:48
@ekohl ekohl linked an issue Nov 25, 2020 that may be closed by this pull request
Add Puppet version support range 5.5.8 < 7.0.0 to metadata.json #15
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
modulesync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Puppet version support range 5.5.8 < 7.0.0 to metadata.json
2 participants
@bastelfreak @ekohl