fix for issue 21 "Autoloading and XmlLens loading fails" #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
error "Could not autoload puppet/type/xmlfile: no such file to load -- puppet_x/vox_pupuli/xmlfile/lens"
error "change from 'absent' to 'present' failed: Could not set 'present' on ensure: uninitialized constant XmlLens"
|
looks good to me. @alexjfisher what is your opinion? |
alexjfisher
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Hopefully fixes the issue 21 loading lens.rb and using Lens class instead of XmlLens
This Pull Request (PR) fixes the following issues
Fixes #21
Warning: I am neither puppet nor ruby expert, I have just tried something and it had worked. But it's possible that it is incorrect. Expert review required! Thank you.