Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zabbix Repository (zabbix-non-supported) defined with incorrect gpgkey #397

Closed
jamescook000 opened this issue Jun 5, 2017 · 7 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@jamescook000
Copy link

jamescook000 commented Jun 5, 2017

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: 4.10.1
  • Ruby: 2.0.0p648
  • Distribution: Centos 7
  • Module version: 4.0.0

How to reproduce (e.g Puppet code you use)

The code used is straight from the modules example:

class { 'apache':
mpm_module => 'prefork',
}
include apache::mod::php
class { 'postgresql::server': }
class { 'zabbix':
zabbix_version => '3.2',
zabbix_url => 'localhost',
}

What are you seeing

When trying to install any rpm from the zabbix-nonsupported repository it fails with the following GPG key error message:

The GPG keys listed for the "Zabbix_nonsupported_7_x86_64" repository are already installed but they are not correct for this package.
Check that the correct key URLs are configured for this repository.

What behaviour did you expect instead

No errors and Zabbix to install as per module.

Output log

Error: Execution of '/usr/bin/yum -d 0 -e 0 -y install zabbix-server-pgsql' returned 1: warning: /var/cache/yum/x86_64/7/Zabbix_nonsupported_7_x86_64/packages/fping-3.10-1.el7.x86_64.rpm: Header V4 DSA/SHA1 Signature, key ID 79ea5ed4: NOKEY

The GPG keys listed for the "Zabbix_nonsupported_7_x86_64" repository are already installed but they are not correct for this package.
Check that the correct key URLs are configured for this repository.

Failing package is: fping-3.10-1.el7.x86_64
GPG Keys are configured as: http://repo.zabbix.com/RPM-GPG-KEY-ZABBIX-A14FE591
Error: /Stage[main]/Zabbix::Server/Package[zabbix-server-pgsql]/ensure: change from purged to present failed: Execution of '/usr/bin/yum -d 0 -e 0 -y install zabbix-server-pgsql' returned 1: warning: /var/cache/yum/x86_64/7/Zabbix_nonsupported_7_x86_64/packages/fping-3.10-1.el7.x86_64.rpm: Header V4 DSA/SHA1 Signature, key ID 79ea5ed4: NOKEY

The GPG keys listed for the "Zabbix_nonsupported_7_x86_64" repository are already installed but they are not correct for this package.
Check that the correct key URLs are configured for this repository.

Failing package is: fping-3.10-1.el7.x86_64
GPG Keys are configured as: http://repo.zabbix.com/RPM-GPG-KEY-ZABBIX-A14FE591

Any additional information you'd like to impart

This is due to commit ac9002c modifying the GPG key for Zabbix 3.2+ for both the Zabbix and Zabbix-nonsupported repository.

However the Zabbix-nonsupported should have remained unmodified as the GPG key was never changed by Zabbix SIA (gpgkey => 'http://repo.zabbix.com/RPM-GPG-KEY-ZABBIX')

@bastelfreak
Copy link
Member

Hi @jamescook000, thanks for the bugreport. I'm currently working on a fix. Hopefully I can push it today.

@bastelfreak
Copy link
Member

Hi @jamescook000, can you take a look at the PR and test if this resolves your issue?

@jamescook000
Copy link
Author

HI,

Yes thanks the code updates and I have tested and it does resolve the issue.

Cheers
James

@bastelfreak
Copy link
Member

Thanks for the feedback!

@frenchtoasters
Copy link
Contributor

This also was not working for me, after a little digging though i found this http://repo.zabbix.com/ and changed the the following in repo.pp:

# Zabbix-3.2 and newer RPMs are signed with the GPG key
        if versioncmp($zabbix_version, '3.2') < 0 {
          $gpgkey = 'http://repo.zabbix.com/RPM-GPG-KEY-ZABBIX'
        }
        else {
          $gpgkey = 'http://repo.zabbix.com/RPM-GPG-KEY-ZABBIX-79EA5ED4'
          #$gpgkey = 'http://repo.zabbix.com/RPM-GPG-KEY-ZABBIX-A14FE591'
        }

@bastelfreak
Copy link
Member

@frenchtoasters which zabbix version and which module version did you use?

@bastelfreak bastelfreak reopened this Mar 29, 2018
@frenchtoasters
Copy link
Contributor

Sorry just noticed this, i found that i was using on version back after this and that had the fix IIRC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants