Fix rpm key handling + changing default values depending on zabbix version #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zabbix introduced one new key for 3.2 releases, but that one is currently only used in the main repo. Noticed this by doing acceptance tests \o/
This is needed to allow upgrades after a changed zabbix_version parameter. In general this is a safe option, since zabbix only pushes patch releases into the same repository.
alexjfisher
reviewed
Jun 5, 2017
manifests/params.pp
Outdated
| @@ -68,7 +68,7 @@ | |||
| } | |||
|
|
|||
| # Zabbix overall params. Is used by all components. | |||
| $zabbix_package_state = 'present' | |||
| $zabbix_package_state = 'latest' | |||
There was a problem hiding this comment.
I'm not sure this is a good idea. Nothing will automatically bump zabbix_version when updated packages get installed.
There was a problem hiding this comment.
this is for the use case that somebody runs zabbix 3.0 or 2.4 and wants to update to 3.2.
There was a problem hiding this comment.
yeah, but this would then just happen whilst zabbix_version would still say 2.4 or whatever. Incompatible configuration would then be applied. I think you need a separate parameter for package_version.
bastelfreak
force-pushed
the
rpm_keys
branch
3 times, most recently
from
637b507
to
e17872e
Compare
We now do proper acceptance tests for zabbix-agent. We first install the oldest, but still supported, version 2.4. After that we upgrade it to the newest version, 3.2.
this is a really really nasty bug. A few of the default values we provide depend on the zabbix version. Their default value is different based on the zabbix version. We deal with this in the params.pp, but that codeblock is always ignored if you provide a zabbix version by yourself. This is now fixed and proven to work by acceptance tests.
alexjfisher
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are multiple bugs that I found while doing acceptance testing. The implementation is described in the individual commit messages. This fixes #398 and #397 and is based on the work from #396 and #382