Remove dependency on concat #658
Assignees
Comments
Merged
alexjfisher
added a commit
to alexjfisher/puppet-zabbix
that referenced
this issue
Feb 21, 2020
We don't use it directly in this module. It *is* a dependency of at least one of our dependencies, so it needs to remain in .fixtures.yml. Fixes voxpupuli#658
|
I think you're right, so I'll fix it here. You may want to open a PR over at https://github.com/openstack/puppet-ceph too. |
ljeromets
pushed a commit
to ljeromets/puppet-zabbix
that referenced
this issue
Mar 4, 2020
We don't use it directly in this module. It *is* a dependency of at least one of our dependencies, so it needs to remain in .fixtures.yml. Fixes voxpupuli#658
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Affected Puppet, Ruby, OS and module versions/distributions
How to reproduce (e.g Puppet code you use)
Seen when building an environment using
librarian-puppetwhere other modules have a dependency onpuppetlabs/concatversion < 3.0 (in our case the ceph module). The zabbix module want >= 4.1.0What are you seeing
Conflicting dependencies around the concat module.
What behaviour did you expect instead
No Conflict
Output log
Any additional information you'd like to impart
puppetlabs/concatis not even a soft dependency for the zabbix module, as only the zabbix modules own dependencies use it. Setting a fact should not be enough reason to have a module dependency (concat_basedir).I think the CEPH module makes as much use of
puppetlabs/concatas zabbix (ie only it's dependencies use concat).The text was updated successfully, but these errors were encountered: