Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

startup_script fails for windows #817

Closed
logicminds opened this issue Mar 4, 2022 · 1 comment
Closed

startup_script fails for windows #817

logicminds opened this issue Mar 4, 2022 · 1 comment
Labels
good first issue Good for newcomers

Comments

@logicminds
Copy link
Contributor

This bug is caused due to a case sensitivity issue with the service name for windows. On windows the service name is capitalized while everything else it is lowercase. This causes the service to not start because the fail function is executed. A case insensitive comparison will fix this issue.

https://github.com/voxpupuli/puppet-zabbix/blob/master/manifests/startup.pp#L32

https://github.com/voxpupuli/puppet-zabbix/blob/master/manifests/params.pp#L103

What are you seeing

The catalog fails: we currently only support a title that contains agent or server

What behaviour did you expect instead

The catalog to complete sucessfully

Output log

Any additional information you'd like to impart
@smortex
Copy link
Member

smortex commented Mar 5, 2022

Puppet string comparison is not case sensitive, but repexp are. One can make them case insensitive but the syntax is not that readable, maybe better downcase the service name 😉

@smortex smortex added the good first issue Good for newcomers label Mar 5, 2022
logicminds added a commit that referenced this issue Mar 9, 2022
@logicminds
Fix #817 - startup_script fails for windows
a434381 
   * Previously the windows agent puppet code did not handle windows
     properly and failed the catalog build due to a case sensitive issue.
     This fixes that by downcase the agent name first.
logicminds added a commit that referenced this issue Mar 9, 2022
@logicminds
Fix #817 - startup_script fails for windows
2c077d7 
   * Previously the windows agent puppet code did not handle windows
     properly and failed the catalog build due to a case sensitive issue.
     This fixes that by downcase the agent name first.
logicminds added a commit that referenced this issue Mar 9, 2022
@logicminds
Fix #817 - startup_script fails for windows
c13872c 
   * Previously the windows agent puppet code did not handle windows
     properly and failed the catalog build due to a case sensitive issue.
     This fixes that by downcase the agent name first.
bastelfreak added a commit that referenced this issue Mar 10, 2022
@bastelfreak
Merge pull request #818 from voxpupuli/fix-zabbix-agent
120d1bc 
 Fix #817 - startup_script fails for windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@smortex @logicminds