Fix #817 - startup_script fails for windows #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logicminds
force-pushed
the
fix-zabbix-agent
branch
from
a434381
to
2c077d7
Compare
|
thanks for the PR. on which windows versions did you test / are they missing in https://github.com/voxpupuli/puppet-zabbix/blob/master/metadata.json#L143-L149 ? |
logicminds
force-pushed
the
fix-zabbix-agent
branch
from
2c077d7
to
c13872c
Compare
|
Yea this was on 2019, but it is a code issue and not a platform one. Anyways 2019 work great so I think adding 2019 is applicable. Do you want me to update the metadata to include that? |
|
yes, please add it :) (and if you've really much spare time and could submit windows facts to https://github.com/voxpupuli/facterdb/pulls I will add you to my chocolate-giftlist-for-future-conferences) |
* Previously the windows agent puppet code did not handle windows
properly and failed the catalog build due to a case sensitive issue.
This fixes that by downcase the agent name first.
bastelfreak
force-pushed
the
fix-zabbix-agent
branch
from
deda2ff
to
b8bcf2f
Compare
|
I will fix the arch linux failures in another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
properly and failed the catalog build due to a case sensitive issue.
This fixes that by downcase the agent name first.