Update proxy.pp, fix Error: ...install zabbix-proxy- .. #159
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
thank you for the quick fixing of the issue Database is always managed #153
I tried running puppet fix the fix but got:
Error: Execution of '/usr/bin/apt-get -q -y -o DPkg::Options::=--force-confold install zabbix-proxy-' returned 100: Reading package lists... Building dependency tree... Reading state information... E: Unable to locate package zabbix-proxy Error: /Stage[main]/Zabbix::Proxy/Package[zabbix-proxy-]/ensure: change from purged to present failed: Execution of '/usr/bin/apt-get -q -y -o DPkg::Options::=--force-confold install zabbix-proxy-' returned 100: Reading package lists... Building dependency tree... Reading state information... E: Unable to locate package zabbix-proxy
After a quick look into the fix, I saw that there part where db variable is set was not reachable if the database is managed.
So I extracted the file name building depending on DB type to an extra loop.