New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update proxy.pp, fix Error: ...install zabbix-proxy- .. #159

Merged
merged 1 commit into from Feb 1, 2016

Conversation

Projects
None yet
2 participants
@subkowlex
Copy link
Contributor

subkowlex commented Feb 1, 2016

Hi,
thank you for the quick fixing of the issue Database is always managed #153
I tried running puppet fix the fix but got:

Error: Execution of '/usr/bin/apt-get -q -y -o DPkg::Options::=--force-confold install zabbix-proxy-' returned 100: Reading package lists... Building dependency tree... Reading state information... E: Unable to locate package zabbix-proxy Error: /Stage[main]/Zabbix::Proxy/Package[zabbix-proxy-]/ensure: change from purged to present failed: Execution of '/usr/bin/apt-get -q -y -o DPkg::Options::=--force-confold install zabbix-proxy-' returned 100: Reading package lists... Building dependency tree... Reading state information... E: Unable to locate package zabbix-proxy

After a quick look into the fix, I saw that there part where db variable is set was not reachable if the database is managed.

So I extracted the file name building depending on DB type to an extra loop.

Update proxy.pp, fix Error: ...install zabbix-proxy- ..
extracted the file name building depending on DB type to an extra loop for the case where database is not managed

dj-wasabi added a commit that referenced this pull request Feb 1, 2016

Merge pull request #159 from subkowlex/master
Update proxy.pp, fix Error: ...install zabbix-proxy- ..

@dj-wasabi dj-wasabi merged commit 1bd43b4 into voxpupuli:master Feb 1, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@dj-wasabi

This comment has been minimized.

Copy link
Collaborator

dj-wasabi commented Feb 1, 2016

Thanks!

@dj-wasabi dj-wasabi added this to the 2.1.0 milestone Feb 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment