Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update README.md so everything is rendered correctly #370

Merged
merged 1 commit into from
Mar 23, 2017
Merged

update README.md so everything is rendered correctly #370

merged 1 commit into from
Mar 23, 2017

Conversation

Cosaquee
Copy link
Contributor

No description provided.

README.md Outdated

* `templ_name`: The name of the template. This name will be found in the Web interface.
* `templ_source`: The location of the XML file wich needs to be imported.

##limitations
## limitations
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we switch to "Limitations"?

@bastelfreak bastelfreak added the docs Improvements or additions to documentation label Mar 23, 2017
@bastelfreak
Copy link
Member

Thanks for the PR @Cosaquee! We should really use a markdown validator...

@Cosaquee
Copy link
Contributor Author

@bastelfreak do you have any specific validator in mind ? I found https://github.com/mivok/markdownlint and I can probably spend some time and see how it works and connect it to this repo, in form of rake task. : )

@bastelfreak
Copy link
Member

We manage all our rake tasks with a central modulesync_config repository. We already have an (older) issue about markdown linting. voxpupuli/modulesync_config#182

Contributions are always welcome. Feel free to comment on it or provide an example. You can add a linter to any of our repos and we can later adopt it to modulesync, which then provides it to all of our modules.

@Cosaquee
Copy link
Contributor Author

Cosaquee commented Mar 23, 2017

For now i think it is good idea to merge this PR so README can be readable again. In mean time i will research problem of Markdown linting and open new PR if i will have some code ready.

@bastelfreak
Copy link
Member

please check my inline comment. I think we should switch limitations to Limitations? Since all the other headlines start with a capital letter.

@Cosaquee
Copy link
Contributor Author

@bastelfreak done :)

@bastelfreak
Copy link
Member

can you check the readme again? There are: '###Usage zabbix-agent' and '###Usage zabbix-proxy' which also need an additional whitespace.

@igalic igalic merged commit 4829738 into voxpupuli:master Mar 23, 2017
@Cosaquee Cosaquee deleted the feature/update-readme branch March 23, 2017 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants