Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test markdown #182

Open
roidelapluie opened this issue Jun 16, 2016 · 9 comments
Open

test markdown #182

roidelapluie opened this issue Jun 16, 2016 · 9 comments

Comments

@roidelapluie
Copy link
Member

15:13:09 < roidelapluie> we should test Markdown
15:13:18 < roidelapluie> e.g multiple newlines

@igalic
Copy link
Contributor

igalic commented Jun 16, 2016

@roidelapluie wow, you're almost as bad at making issues as i am :P


basically, what i'm trying to say is: what do you mean, test markdown? and how should we do this? How does it belong into modulesync_config?

@roidelapluie
Copy link
Member Author

We should add a test in .travis.yaml that could check the markdown files of the project for style errors

@igalic
Copy link
Contributor

igalic commented Jun 16, 2016

👍 💯 🎉

@juniorsysadmin
Copy link
Member

Let's just use the mdl Ruby gem with a style file

@dhoppe
Copy link
Member

dhoppe commented Sep 17, 2016

Sounds great, even if it means we have a lot to fix. Just go to this issue and give the comment of @jyaworski a +1. ;)

@morremeyer
Copy link

You can use a workaround we also use:

desc 'Linting for all markdown files'
task 'markdown_lint' do
  require 'mdl'

  ARGV = [ 'site', 'documentation', 'README.md', ]
  MarkdownLint::run
end

However, it’s a really nasty one :/

@bastelfreak
Copy link
Member

@mauricemeyer would you be interested in providing a PR to one of our modules that implements this? If it works, we can adopt it to this repo and roll it out to all modules.

@dhoppe
Copy link
Member

dhoppe commented Apr 2, 2019

I think the ARGV should be less static, because some of our modules provide a REFERENCE.md.

@morremeyer
Copy link

@bastelfreak We switched to DavidAnson/markdownlint as we needed the possibility to disable linting for certain sections/files.

As its in JS, I made our repository a pseudo-npm package for the sake of a simple npm install.

I’ll gladly provide a PR, but you’ll have to decide which of the two tools you want it implemented with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants