drop legacy puppetlabs/pe_gem dependency & cleanup code #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
requested changes
Oct 6, 2019
This module was required to support EOL Puppet/Puppet Enterprise versions. We don't support them since a long time, so we can remove the dependency + related code.
|
ups. I had it already removed from the metadata.json but it got readded during a rebase. I don't think that this is a breaking change since we officially dropped support for those puppet/pe versions some time ago in another release. But since the next release will be a major one we could also mark it as |
bastelfreak
added
backwards-incompatible
and removed
enhancement
ekohl
approved these changes
Oct 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module was required to support EOL Puppet/Puppet Enterprise
versions. We don't support them since a long time, so we can remove the
dependency + related code.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues