Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type error on zabbix_proxy delete #663

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Fix type error on zabbix_proxy delete #663

merged 1 commit into from
Apr 14, 2020

Conversation

baurmatt
Copy link
Contributor

@baurmatt baurmatt commented Mar 2, 2020

zbx.proxies.delete expects an array, we handed over a string. This fixes
it a adds proper tests.

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

@baurmatt
Copy link
Contributor Author

baurmatt commented Mar 2, 2020

Travis for Ubuntu 16.04:

Error: Unable to connect to PostgreSQL server! (:5432)

  Error: /Stage[main]/Postgresql::Server::Service/Postgresql_conn_validator[validate_service_is_running]/ensure: change from 'absent' to 'present' failed: Unable to connect to PostgreSQL server! (:5432)

I think the error is unrelated because:

  1. Works on my machine ;)
  2. Happens on master as well
  3. Works for all other OSs

@baurmatt
Fix type error on zabbix_proxy delete
9f956cb 
zbx.proxies.delete expects an array, we handed over a string. This fixes
it a adds proper tests.
@bastelfreak bastelfreak added the bug Something isn't working label Apr 14, 2020
@bastelfreak bastelfreak merged commit dcc5a0e into voxpupuli:master Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baurmatt @bastelfreak