Cleanup and fix acceptance test helper #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
commented
Apr 19, 2020
| /opt/puppetlabs/bin/puppet resource service zabbix-server ensure=stopped | ||
| /opt/puppetlabs/bin/puppet resource package zabbix-server-pgsql ensure=purged | ||
| rm -f /etc/zabbix/.*done | ||
| if id postgres > /dev/null 2>&1; then |
There was a problem hiding this comment.
I labeled this as bug because in the past, the code didn't check if the user exists. The spec tests worked by accident because the first test added the user and the other depended on them. Tests in the past failed if you tried to execute them standalone.
bastelfreak
commented
Apr 19, 2020
| @@ -17,3 +17,5 @@ | |||
| end | |||
| end | |||
| end | |||
|
|
|||
| Dir['./spec/support/acceptance/**/*.rb'].sort.each { |f| require f } | |||
There was a problem hiding this comment.
I will add that to modulesync_config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues