New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use provided database port in pgpass #851
Conversation
a40ab03
to
50c0b5a
Compare
manifests/database/postgresql.pp
Outdated
@@ -68,10 +68,12 @@ | |||
} | |||
} | |||
|
|||
$db_port = pick($database_port, '5432') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of the pick, I think it makes sense to set $database_port to 5432 as default value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, the previously mentioned line 48 would be deleted, and the test adjusted like I pushed just now. Is it what you have in mind?
(I just figured out how the suggestion in github worked, I could have make a suggestion directly here, sorry!)
f34bb40
to
74f9994
Compare
74f9994
to
ec79e54
Compare
I’ve squashed my commits to be cleaner, feel free to ask f you want me to squash it further |
na it is fine the way it is :) lets see what CI says |
Well, the CI will surely crash because of renaming of template as i said in #854 (comment), so I’m sure I won’t have any green tick right now 😄 |
@teluq-pbrideau so, if we rebase this one on top of master it should pass 😀 ? From your working directory:
|
refactor: more readable code
test: fix custom database port
fix: linter
ec79e54
to
8d4eda5
Compare
Pull Request (PR) description
When configuring a postgresql database that is not running on port 5432, the
.pgpass
is not correctly configured.Then, the
exec { 'zabbix_server_create.sql':}
does not succeed as the server could not connect to the database.