Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/rename Linux SNMP templates for Zabbix 6.0+ #855

Merged
merged 2 commits into from Dec 6, 2022

Conversation

teluq-pbrideau
Copy link
Contributor

Pull Request (PR) description

As mentionned in #851, the SNMP templates has been renamed upstream, this is an attempt to fix the tests

This Pull Request (PR) fixes the following issues

@teluq-pbrideau
Copy link
Contributor Author

teluq-pbrideau commented Dec 2, 2022

But I have no idea how to fix the archlinux tests:

An error occurred in a `before(:suite)` hook.
Beaker::Host::CommandFailure:
  Host 'archlinuxrolling-64.example.com' exited with 1 running:
   puppet module install puppetlabs-postgresql -v 7.5.0
  Last 10 lines of output were:
  	Could not find 'english' (>= 0.a) among 97 total gem(s)
  	Checked in 'GEM_PATH=/root/.local/share/gem/ruby/3.0.0:/usr/lib/ruby/gems/3.0.0' , execute `gem env` for more information

Does someone know anything about this cryptic error? Should we simply disable the archlinux tests suite?

@kenyon
Copy link
Member

kenyon commented Dec 2, 2022

No need to address the archlinux test failure in this PR. That is happening on all of our modules and needs to be fixed in the files that are shared by all of the modules.

test: snmp renamed only on 6.0

test: linter
Co-authored-by: Romain Tartière <romain@blogreen.org>
@smortex
Copy link
Member

smortex commented Dec 5, 2022

This looks good, I will merge it unless CI detect some kind of breakage.

I think it is much more of an enhancement for bringing support for newer versions of Zabbix than a bugfix, so maybe we can change the PR title to something like "Add Linux SNMP templates for Zabbix 6.0+" which will have move value when read in the changelog without context?

@teluq-pbrideau teluq-pbrideau changed the title SNMP template renamed upstream Add/rename Linux SNMP templates for Zabbix 6.0+ Dec 5, 2022
@teluq-pbrideau
Copy link
Contributor Author

I think it is much more of an enhancement for bringing support for newer versions of Zabbix than a bugfix, so maybe we can change the PR title to something like "Add Linux SNMP templates for Zabbix 6.0+" which will have move value when read in the changelog without context?

It was a change from upstream in 6.0.11, it was still named Linux SNMP in 6.0.10:
https://git.zabbix.com/projects/ZBX/repos/zabbix/browse/templates/os/linux_snmp_snmp/template_os_linux_snmp_snmp.yaml?at=refs%2Ftags%2F6.0.10

@teluq-pbrideau
Copy link
Contributor Author

well... Is zabbix 6 still supported on centos7?

  Error downloading packages:
    zabbix-agent-6.0.12-release1.el7.x86_64: [Errno 256] No more mirrors to try.
  Error: /Stage[main]/Zabbix::Agent/Package[zabbix-agent]/ensure: change from '5.4.12-1.el7' to '0:6.0.12-release1.el7' failed: Could not update: Execution of '/usr/bin/yum -d 0 -e 0 -y update zabbix-agent' returned 1: Delta RPMs disabled because /usr/bin/applydeltarpm not installed.

@smortex
Copy link
Member

smortex commented Dec 5, 2022

well... Is zabbix 6 still supported on centos7?

Packages seems to exist. Maybe a transient failure?
https://repo.zabbix.com/zabbix/6.0/rhel/7/x86_64/

@smortex
Copy link
Member

smortex commented Dec 6, 2022

Great, we will assume the failure was due to the repo being updated while the test suite was running 🤷

@smortex smortex merged commit c7059e4 into voxpupuli:master Dec 6, 2022
@teluq-pbrideau
Copy link
Contributor Author

Thanks @smortex for all the help to merge my stuff!

@evgeni evgeni added the enhancement New feature or request label Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants