move zabbixapi gem installation into own class #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Nov 7, 2023
| 'Debian' => ['make', 'g++', 'ruby-dev', 'ruby', 'pkg-config',], | ||
| default => [], | ||
| } | ||
| ensure_packages($compile_packages) |
There was a problem hiding this comment.
that is deprecated, please use the newer version:
Suggested change
| ensure_packages($compile_packages) | |
| stdlib::ensure_packages($compile_packages) |
There was a problem hiding this comment.
can I use this now w/o bumping stdlib to >= 9?
There was a problem hiding this comment.
Then I'd prefer not to bump stdlib to >= 9 just yet.
ekohl
reviewed
Nov 7, 2023
| # Determine correct zabbixapi version. | ||
| case $zabbix_version { | ||
| /^[56]\.[024]/: { | ||
| $zabbixapi_version = '5.0.0-alpha1' |
There was a problem hiding this comment.
Note to self: https://rubygems.org/gems/zabbixapi does only list a 5.0.0-alpha1 from 2021.
ekohl
approved these changes
Nov 7, 2023
ekohl
reviewed
Nov 7, 2023
Comment on lines
+6
to
+7
| $zabbix_version = $zabbix::params::zabbix_version, | ||
| $puppetgem = $zabbix::params::puppetgem, |
There was a problem hiding this comment.
Should this be String[1] for both?
There was a problem hiding this comment.
In theory, yes.
In reality, we do not enforce these anywhere else, so I find it odd to do it here.
(read: we should do it globally, but not in this PR)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues