This repository has been archived by the owner on Jan 29, 2022. It is now read-only.
Create r10k log proxy #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
approved these changes
Aug 27, 2020
bastelfreak
approved these changes
Aug 27, 2020
bastelfreak
approved these changes
Aug 27, 2020
igalic
reviewed
Aug 27, 2020
| super('puppet_webhook') | ||
|
|
||
| @logger = logger | ||
| @logger.level = level |
There was a problem hiding this comment.
what's the point of passing logger and level? above we extract level from logger, and here we initialise logger's level that we got passed
are those ever different?
There was a problem hiding this comment.
Probably not, I was just being safe.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new R10K log proxy to get r10k logging to the webhook logger. Also removed SINATRA_ENV in favor of just using RACK_ENV
closes #146