Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show catalog failures in overview node list #95

Closed
henderb opened this issue Oct 31, 2014 · 12 comments
Closed

Show catalog failures in overview node list #95

henderb opened this issue Oct 31, 2014 · 12 comments
Labels
enhancement

Comments

@henderb
Copy link

henderb commented Oct 31, 2014

I wish nodes whose catalog compilation failed would show in the node list.
@corey-hammerton
Copy link
Contributor

When the puppet server experiences errors in the catalog compilation it only logs it and stops. When that happens it does NOT record it in puppetdb and therefore cannot be queried by puppetboard.

@henderb
Copy link
Author

henderb commented Nov 1, 2014

I figured that might be the case. Could it show as unreported?

@corey-hammerton
Copy link
Contributor

It will after the time configured in UNRESPONSIVE_HOURS

The process in puppet on runs is

replace facts
replace catalog
store reports

@henderb
Copy link
Author

henderb commented Nov 1, 2014

I'll have to test it to make sure, but I've had nodes failing for a day or so and I don't think they were listed. It's set to the default 2 hours.

@henderb
Copy link
Author

henderb commented Nov 3, 2014

I think my nodes are using the cached catalog during normal runs, just not when I do puppet agent -tv

@henderb henderb closed this as completed Nov 3, 2014
@corey-hammerton
Copy link
Contributor

The only way that I've noticed that you can detect this in puppetboard is comparing the timestamps of the catalog and the latest report.

Normally they should be within a few seconds of each other.

@daenney
Copy link
Member

daenney commented Nov 9, 2014

Hmmm, that's an interesting theory. Unfortunately I've had the experience of catalog compilations that take well over 5 minutes but if we could define a threshold there it might be worth looking into it.

@gdubicki
Copy link
Member

Hey, I would also be happy to see compilation errors in puppetboard. And if I got https://tickets.puppetlabs.com/browse/PDB-16 right and if that info is still up to date, then information about such run actually is pushed to puppetdb, so it can be pulled out by puppetboard. So can we please reopen this ticket?

@bastelfreak bastelfreak reopened this Aug 11, 2018
@bastelfreak
Copy link
Member

@gdubicki I reopened the ticket. Are you interested in providing a patch for this?

@gdubicki
Copy link
Member

Actually it seems that with latest puppetboard and puppetdb the former does show compilation errors. Sorry for making you think otherwise, @bastelfreak . I think that this issue can be closed as "resolved".

@gdubicki
Copy link
Member

I have put results of my verification that it does work in #449.

b4ldr pushed a commit to b4ldr/puppetboard that referenced this issue Feb 19, 2020
@corey-hammerton
pypuppetdb/api.py: Fixing last_report calculation bug causing all nod…
5f1e283 
…es to report unreported (voxpupuli#98)

This fixes voxpupuli#95

One of the intended code cleanups from this release was to combine the
report_timestamp datetime variable into a single line. This bug unintentionally
caused all nodes in the result set to report a status of unreported.

Also caching the `datetime.now()` code to outside the loop, calling it only
once instead of once-per-node.
@gdubicki
Copy link
Member

Resolved with ead45c9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@henderb @bastelfreak @gdubicki @daenney @corey-hammerton