puppetboard/app.py: Simplifying the Inventory Code #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Inventory This resolves #275 This update eliminates one iteration over the resulting inventory facts that generates a multidimensional dictionary keyed by the node's certname to another dictionary of key-value pairs of the fact name and fact value.
|
@corey-hammerton The template for the inventory page still doesn't link to the node page as presented #280. Could you consider this improvemt fro your PR? |
…ks to the Node page This comes as a request from #280
|
@tux-o-matic I've updated this PR, does this fit with your request? |
|
@corey-hammerton thanks, that should do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #275
This update eliminates one iteration over the resulting inventory facts
that generates a multidimensional dictionary keyed by the node's certname
to another dictionary of key-value pairs of the fact name and fact value.