New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revamp catalog page with paging #353

Merged

mterzo merged 3 commits into voxpupuli:master from redref:catalogs

Feb 15, 2017

Contributor

redref commented Feb 3, 2017

Revamped in a two step selection.


          Revamp catalog page: paging + datatables

b947bf0

coveralls commented Feb 3, 2017

Coverage increased (+4.8%) to 74.015% when pulling 00765d0 on redref:catalogs into 35486e8 on voxpupuli:master.

1 similar comment

coveralls commented Feb 3, 2017 •

edited

Coverage increased (+4.8%) to 74.015% when pulling 00765d0 on redref:catalogs into 35486e8 on voxpupuli:master.


          Add some tests to catalogs

4190e36

redref force-pushed the catalogs branch from 00765d0 to 4190e36 Compare

February 3, 2017 22:11

coveralls commented Feb 3, 2017 •

edited

Coverage increased (+5.3%) to 74.453% when pulling 4190e36 on redref:catalogs into 35486e8 on voxpupuli:master.

Contributor

mterzo commented Feb 4, 2017

Awesome test code! Now to add some mocks to get data out of faked pypuppet.

coveralls commented Feb 4, 2017 •

edited

Coverage increased (+5.1%) to 74.307% when pulling a40eb45 on redref:catalogs into 35486e8 on voxpupuli:master.

Contributor Author

redref commented Feb 4, 2017

Added some testing. But, I don't test paging yet. I have some ideas to extend testing on this point. If you agree, I plan to do it with my coming 'Overview / Nodes paging revamp' PR as it will require changes to 'mock_puppetdb_default_nodes'.

Removed skipped node as this status is not ever coming from pypuppetdb.

Contributor

mterzo commented Feb 4, 2017

Yeah. Shouldn't be too bad. I was looking at phantomjs as well. Wondering how to test all this JavaScript.

mterzo added this to the 0.3.0 milestone


          Catalogs tests - better data testing

f908a1e

redref force-pushed the catalogs branch from a40eb45 to f908a1e Compare

February 6, 2017 15:20

coveralls commented Feb 6, 2017 •

edited

Coverage increased (+5.1%) to 74.307% when pulling f908a1e on redref:catalogs into 35486e8 on voxpupuli:master.

6 similar comments

coveralls commented Feb 6, 2017

Coverage increased (+5.1%) to 74.307% when pulling f908a1e on redref:catalogs into 35486e8 on voxpupuli:master.

coveralls commented Feb 6, 2017

Coverage increased (+5.1%) to 74.307% when pulling f908a1e on redref:catalogs into 35486e8 on voxpupuli:master.

coveralls commented Feb 6, 2017

Coverage increased (+5.1%) to 74.307% when pulling f908a1e on redref:catalogs into 35486e8 on voxpupuli:master.

coveralls commented Feb 6, 2017

Coverage increased (+5.1%) to 74.307% when pulling f908a1e on redref:catalogs into 35486e8 on voxpupuli:master.

coveralls commented Feb 6, 2017

Coverage increased (+5.1%) to 74.307% when pulling f908a1e on redref:catalogs into 35486e8 on voxpupuli:master.

coveralls commented Feb 6, 2017

Coverage increased (+5.1%) to 74.307% when pulling f908a1e on redref:catalogs into 35486e8 on voxpupuli:master.

mterzo merged commit fd4051b into voxpupuli:master

redref deleted the catalogs branch

February 15, 2017 20:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment