Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle server exception when unable to connect early. #393

Merged
merged 3 commits into from
Jul 8, 2017
Merged

Handle server exception when unable to connect early. #393

merged 3 commits into from
Jul 8, 2017

Conversation

mterzo
Copy link
Contributor

@mterzo mterzo commented Jul 1, 2017 •
edited
Loading

Had to refactor a bit of code to get error handling before the creating the puppetdb object.

Also adding back pep8 formatting requirements in travis.

Fixed #392

@mterzo
Refactor out some global space to allow for testable code
9488e8c 
and handling error conditions before flask is completely
initialized.
@coveralls
Copy link

coveralls commented Jul 1, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.9%) to 81.275% when pulling 24761e7 on mterzo:clean_error into df91583 on voxpupuli:master.

@bastelfreak
Copy link
Member

Hi @mterzo, there is a typo in the second commit:
"Addingn" -> "Adding"

@mterzo
Copy link
Contributor Author

mterzo commented Jul 5, 2017

@bastelfreak Good catch.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.9%) to 81.275% when pulling 7bef20b on mterzo:clean_error into df91583 on voxpupuli:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.9%) to 81.275% when pulling 7bef20b on mterzo:clean_error into df91583 on voxpupuli:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.9%) to 81.275% when pulling 7bef20b on mterzo:clean_error into df91583 on voxpupuli:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.9%) to 81.275% when pulling 7bef20b on mterzo:clean_error into df91583 on voxpupuli:master.

@mterzo mterzo added the bug label Jul 6, 2017
@bastelfreak bastelfreak merged commit 9bd0784 into voxpupuli:master Jul 8, 2017
@mterzo mterzo deleted the clean_error branch November 10, 2017 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mterzo @coveralls @bastelfreak