CommonMark >= 0.8.x preparation (rebased) #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As commonmark package has been renamed to lowercase and removed symlink starting v0.8.1 it will be a good point to import the module directly to lowercase in order to remove the try: block in the future when using a later version of this package: https://github.com/rtfd/CommonMark-py/releases
1 similar comment
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #480, I cherry-picked the author's commit on top of master to prove that the test suite pass with these changes (except the Allowed failure that already fails with master).
Feel free to merge this PR or the original one; and close the other one at your convenience
Fixes #480