Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop modifying the query response for showing as JSON #696

Merged
merged 2 commits into from Jun 12, 2022
Merged

Conversation

gdubicki
Copy link
Member

Fixes #695

@codecov
Copy link

codecov bot commented Jun 12, 2022

Codecov Report

Merging #696 (634a0bf) into master (bb18c9f) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #696      +/-   ##
==========================================
+ Coverage   85.93%   85.95%   +0.02%     
==========================================
  Files          19       19              
  Lines        1059     1061       +2     
==========================================
+ Hits          910      912       +2     
  Misses        149      149              
Impacted Files Coverage Δ
puppetboard/views/query.py 86.66% <100.00%> (+0.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb18c9f...634a0bf. Read the comment docs.

- separately table and raw JSON view,
although we can't test the actual response
as in both cases it's generated with JavaScript
@gdubicki gdubicki merged commit 4ada325 into master Jun 12, 2022
@gdubicki gdubicki deleted the fix_695 branch June 12, 2022 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query page PQL raw does not match puppetdb_query output
2 participants