Add auto-refresh on index page

[timlittle]

Add an auto refresh to the index page.

[daenney]

I'm willing to accept this if and only if it's configurable through settings.py and with the ability to completely disable it.

I personally really dislike sites that just decide to auto-refresh on me because this always happens at the exact moment you're trying to copy-paste something.

[k2patel]

i'm user but i agree, it is only usefull if i can control it.

[timlittle]

Thanks for the suggestion.
I have implemented the changes into the pull-request.

Setting REFRESH_RATE to 0 will disable the refreshing.

[daenney]

Perfect.

Two things:

• Could you add a little piece of documentation to the README about it so people don't suddenly get this behaviour without a fair warning? There's a section about the available configuration settings that might be worth looking into in which this should fit nicely.
• Could you squash all the commits together into one? This is one feature so I'd like to limit it to one commit history wise.

[fgimian]

Hmm, I don't think we should do this for refreshing personally. Instead, we really need to investigate an AJAX-based solution like Angular.js or similar. I'll test this out tomorrow but I'm pretty set on using a strategy that involved Javascript to dynamically update elements on the page instead of refreshing the entire page via a meta tag.

[nibalizer]

I am personally happy with this solution until an AJAX solution emerges. @tjayL can you rebase this and we can merge it?

[nibalizer]

@tjayL rebase?

[timlittle]

Sorry dude,
I have put all my changes in 245e625

[bastelfreak]

@tjayL could you take a look again? it seems like a rebase is needed here.

[timlittle]

I am unsure what you are expecting of me here. I have put all of the changes for this into one commit.

If i do a git rebase i only get 'Current branch master is up to date.'

[bastelfreak]

You've to do a rebase against the master:

git checkout master
git pull upstream # to update your master to the latest one from this remote, not your fork
git checkout auto-refresh
git rebase -i master

this is untested and based on my memory, use the commands with caution. If you experience any issues you can ask here or also in #puppet-community on freenode

[timlittle]

Thanks bastelfreak.

I have done that and pushed it back to my repo.

[bastelfreak]

did you push it in the wrong branch? I can't see anything changed here :(

git is pure magic

[timlittle]

I pushed it into the master branch on my repo:

git remote -v
origin  https://github.com/tjayl/puppetboard.git (fetch)
origin  https://github.com/tjayl/puppetboard.git (push)

git branch -v
  auto-refresh 245e625 Add auto refresh to the index page
* master       245e625 Add auto refresh to the index page

[janorn]

You need to add the original repo as an upstream.

https://help.github.com/articles/configuring-a-remote-for-a-fork/

[janorn]

Or follow these steps.

https://help.github.com/articles/merging-an-upstream-repository-into-your-fork/

[timlittle]

Thanks for those guides.

I think i have managed to do it.

[bastelfreak]

After the rebase you've to push (probably push -f) into your auto-refresh branch, than the changes will appear here. I can't see anything changed here. If you want, we can fiddle that out if you join #puppet-community.

[timlittle]

Got it.

If there are still issues, i will jump on IRC to resolve them

[bastelfreak]

great, you based it \o/

but you missed two pieces off git diff code. could you rebase again and squash it down to one commit?

[bastelfreak]

please remove this line

[timlittle]

rebase done

[bastelfreak]

the code looks fine, could you squash the two commits into one? Than we should finally be ready to merge \o/

[janorn]

https://ariejan.net/2011/07/05/git-squash-your-latests-commits-into-one/

[timlittle]

It doesn't seem to want to squash 245e625 and d44152f

I am guessing because 245e625 was committed over a year ago

[bastelfreak]

Would it be possible for you to create a new branch with just a single commit and a new PR? That could be easier than squashing this one.

[timlittle]

Done it (at last)

[bastelfreak]

thanks, looks perfect!
can somebody merge this or do the docs need to be extended?