Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate symbolized facts #193

Merged
merged 4 commits into from
Jul 4, 2024
Merged

Conversation

bastelfreak
Copy link
Member

No description provided.

@bastelfreak bastelfreak self-assigned this Jun 28, 2024
@bastelfreak bastelfreak changed the title README.md: document symbolized vs stringified facts Deprecate symbolized facts Jun 28, 2024
@bastelfreak
Copy link
Member Author

bastelfreak commented Jun 28, 2024

do we want the backwards-incompatible label here? We already deprecated it in the release summary for 3.0.0: #170

@bastelfreak bastelfreak mentioned this pull request Jun 28, 2024
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.06%. Comparing base (50cff16) to head (89161d0).
Report is 12 commits behind head on master.

Current head 89161d0 differs from pull request most recent head dee9b6b

Please upload reports for the commit dee9b6b to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #193      +/-   ##
==========================================
+ Coverage   94.93%   95.06%   +0.12%     
==========================================
  Files           2        2              
  Lines         158      162       +4     
==========================================
+ Hits          150      154       +4     
  Misses          8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this. Having documentation to refer to is IMHO required for decent adoption.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@bastelfreak bastelfreak force-pushed the deprecate branch 4 times, most recently from ba99b0c to dee9b6b Compare June 28, 2024 17:31
@bastelfreak bastelfreak closed this Jul 2, 2024
@bastelfreak bastelfreak reopened this Jul 2, 2024
README.md Outdated Show resolved Hide resolved
@bastelfreak bastelfreak force-pushed the deprecate branch 3 times, most recently from 875cedc to b7d0be3 Compare July 4, 2024 09:03
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Co-authored-by: Ewoud Kohl van Wijngaarden <ewoud@kohlvanwijngaarden.nl>
@bastelfreak bastelfreak merged commit b2215f6 into voxpupuli:master Jul 4, 2024
7 checks passed
@bastelfreak bastelfreak deleted the deprecate branch July 4, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants