document component vol6 #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youchann
commented
Jan 4, 2021
Comment on lines
+11
to
+19
| <!-- MEMO: Cannot display <Toast /> props type. --> | ||
| <!-- Wait for Storybook updates. --> | ||
| <!-- <ArgsTable of={Toast} /> --> | ||
|
|
||
| The toast is used to show alerts on top of an overlay. The toast will close itself when the close button is clicked, or after a timeout. | ||
|
|
||
| ## Samples | ||
|
|
||
| Explanation of each prop is written in here's [README](https://github.com/jossmac/react-toast-notifications). |
There was a problem hiding this comment.
本当は型を表示したかったのだが、<〇〇.何か />の形式で表現する場合、型の書き方が従来と異なるので、Storybook側が推論してくれない。
ので、被ラッパー側のライブラリを参照させるようにした。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #212
やったコンポーネント
Feedback/に属するコンポーネント全て<LoadingBar /><Snackbar /><Spinner /><Toast />https://deploy-preview-230--ingred-ui.netlify.app/https://deploy-preview-231--ingred-ui.netlify.app/