Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storybookのリファクタリング #212

Closed
53 tasks done
youchann opened this issue Nov 30, 2020 · 11 comments
Closed
53 tasks done

Storybookのリファクタリング #212

youchann opened this issue Nov 30, 2020 · 11 comments

Comments

@youchann
Copy link
Contributor

youchann commented Nov 30, 2020 •
edited

社内の人が実装の参考になるようなStorybookに仕上げる。

やること

  • 新規のStorybookフォーマットを作る

  • 既存の**.storybook.tsxを書き換える

    • ActionButton
    • Backdrop
    • Badge
    • Button
    • ButtonGroup
    • Card
    • Checkbox
    • ClickAwayListener
    • ConfirmModal
    • ContextMenu
    • DataTable
    • DatePicker
    • DateRangePicker
    • Divider
    • DropdownButton
    • ErrorText
    • Fade
    • FileUploader
    • FixedPanel
    • Flex
    • FloatingTip
    • Grow
    • Icon
    • Input
    • ItemEmpty
    • LoadingBar
    • Menu
    • MenuList
    • Modal
    • NavigationRail
    • NotificationBadge
    • Pager
    • Popover
    • Portal
    • RadioButton
    • Select
    • ScrollArea
    • Snackbar
    • Spacer
    • Spinner
    • SplitAnnotation
    • Switch
    • Table
    • TextField
    • Toast
    • ToggleButton
    • Tooltip
    • Typography

  • UIそのものを一覧で眺められるページを追加

  • フォームを追加する際のコードレシピ的なのを追加

  • コンポーネント一覧をカテゴライズして表示
@youchann youchann mentioned this issue Nov 30, 2020
Merged
@youchann
Copy link
Contributor Author

youchann commented Dec 4, 2020

ああ、あとコードレシピ的なのを追加するんだった...memomemo

@youchann
Copy link
Contributor Author

youchann commented Dec 4, 2020

ああ、あとはあれだな、全コンポーネント一覧みたいなのも作るんだった....memomemo

@youchann
Copy link
Contributor Author

youchann commented Dec 7, 2020 •
edited

.mdxを使うのだけれども、補完やLinterがまだ発展途上
ref: microsoft/vscode#92805
ref: https://stackoverflow.com/questions/64596457/how-to-get-mdx-file-support-linting-in-vs-code

ただESLintは動く。

@youchann
Copy link
Contributor Author

youchann commented Dec 7, 2020

memo: 忘れずに対応
#213 (comment)

@youchann
Copy link
Contributor Author

youchann commented Dec 7, 2020

コンポーネント一覧をカテゴライズして表示

Material-uiのやつを踏襲する感じで良いかな

@youchann
Copy link
Contributor Author

UIそのものを一覧で眺められるページを追加

ref: #217

@youchann youchann mentioned this issue Dec 18, 2020
Merged
@youchann
Copy link
Contributor Author

終わったら、デフォルトでDocsが開くようにしたい

This was referenced Dec 18, 2020
Merged
Merged
Merged
Merged
Merged
@youchann youchann mentioned this issue Jan 4, 2021
Merged
@youchann
Copy link
Contributor Author

youchann commented Feb 3, 2021

#241 (comment)
↑あたりで書いているけれど、.mdxじゃなくてもいい感じにかけるということを今更知ってしまった

@youchann
Copy link
Contributor Author

youchann commented Feb 3, 2021 •
edited

文言での説明を要する場合は.mdxを使い、そうでなければ.tsxで書く方針にする

ばらつきが出てしまうが致し方なし。全ては利用者のコピペビリティ向上のため

@youchann youchann mentioned this issue Feb 3, 2021
Merged
@youchann youchann mentioned this issue Feb 15, 2021
Merged
@youchann
Copy link
Contributor Author

memo: 全てリファクタした時点でaddon-knobを取り除く

This was referenced Feb 16, 2021
Merged
Merged
@youchann
Copy link
Contributor Author

こちらはclose

@takurinton takurinton mentioned this issue Sep 14, 2022
Closed
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@youchann