Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add document component 8 #241

Merged
merged 12 commits into from
Feb 3, 2021
Merged

Add document component 8 #241

merged 12 commits into from
Feb 3, 2021

Conversation

youchann
Copy link
Contributor

@youchann youchann commented Feb 3, 2021

ref: #212
今回から複雑な説明を要さないコンポーネントに関しては.tsxを使います。

対応したコンポーネント

  • <ErrorText />
  • <FloatingTip />
  • <Icon />
  • <NotificationBadge />
  • <Pager />
  • <Table />

@youchann youchann self-assigned this Feb 3, 2021
@youchann youchann requested a review from a team as a code owner February 3, 2021 04:57
@youchann youchann changed the title Add document component 8 wip Add document component 8 Feb 3, 2021
"right-start",
// MEMO: Cannot use "ref" with MDX format.
// https://github.com/storybookjs/storybook/issues/10446
export const Sample: React.FunctionComponent<FloatingTipProps> = (args) => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ブランチ環境で<FloatingTip />をみていただけるとわかるのだが.
.tsxの書き方でもいい感じにコピペはできそうだということを把握していなかった...


export const Hoge: React.FunctionComponent<FloatingTipProps> = (args) => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

そして2個目以降のコンポーネントもいい感じにDocs下部に表示されていることを知らなかった

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hogeはあとで消す(説明のための据え置き

@youchann youchann mentioned this pull request Feb 3, 2021
53 tasks
@youchann youchann changed the title wip Add document component 8 Add document component 8 Feb 3, 2021
@ryokosuge
Copy link
Contributor

今回から複雑な説明を要さないコンポーネントに関しては.tsxを使います。

👍

@ryokosuge
Copy link
Contributor

Copy link
Contributor

@ryokosuge ryokosuge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@youchann youchann merged commit 89c821c into master Feb 3, 2021
@youchann youchann deleted the add-document-component-8 branch February 3, 2021 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants