Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document component vol9 #246

Merged
merged 7 commits into from
Feb 17, 2021
Merged

document component vol9 #246

merged 7 commits into from
Feb 17, 2021

Conversation

youchann
Copy link
Contributor

@youchann youchann commented Feb 15, 2021

ref: #212

やったやつ

  • <ButtonGroup />
  • <Checkbox />
  • <DatePicker />
  • <DateRangePicker />
  • <Tooltip />
  • <Typography />

@youchann youchann self-assigned this Feb 15, 2021
@youchann youchann requested a review from a team as a code owner February 15, 2021 05:01
@youchann youchann added the documentation Improvements or additions to documentation label Feb 15, 2021
Copy link
Contributor

@maktak1995 maktak1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@youchann
Copy link
Contributor Author

あれ、reviewリクエストしてました??
まだwipです!!:bow:

@youchann youchann marked this pull request as draft February 15, 2021 06:03
@@ -17,7 +17,7 @@ It can behave like a `<button />` tags.

<Canvas>
<Story
name="example"
name="Example"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Camelにした(.tsxで書いたものがそのようになるため

@youchann youchann changed the title wip document component vol9 document component vol9 Feb 16, 2021
@youchann youchann marked this pull request as ready for review February 16, 2021 04:55
Copy link
Contributor

@ryokosuge ryokosuge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@youchann youchann merged commit 2886aed into master Feb 17, 2021
@youchann youchann deleted the add-document-component-9 branch February 17, 2021 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants