-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@storybook-addon-knobを撤去 #249
Conversation
@@ -62,35 +62,19 @@ describe("{{ input | pascal }} component testing", () => { | |||
|
|||
``` | |||
|
|||
# `{{ input | pascal }}/{{ input | pascal }}.stories.mdx` | |||
# `{{ input | pascal }}/{{ input | pascal }}.stories.tsx` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ついでのscaffdog更新(.mdx
ではなく.tsx
で書いてもらうように)
@@ -22,7 +20,6 @@ module.exports = { | |||
reactOptions: { | |||
fastRefresh: true, | |||
// TODO: fix warn "Rendered more hooks than during the previous render." | |||
// knobを完全に排除できたタイミングで再度調査 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
結局knobが原因ではないことが判明。一旦スルー
@maktak1995 今日じゃなくて大丈夫です(通知申し訳ないです:bow: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
ref: #212
#248 が取り込まれたらマージする。