Multiple Selectで複数選択する際に都度閉じないように修正 #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hirokikondo86
changed the title
hirokikondo86
changed the title
ryokosuge
reviewed
Mar 29, 2021
src/components/Select/Select.tsx
Outdated
| @@ -183,6 +183,7 @@ const Select: SelectComponent = ({ | |||
| <Styled.Container minWidth={minWidth} isDisabled={isDisabled}> | |||
| <ReactSelect | |||
| isClearable | |||
| closeMenuOnSelect={false} | |||
There was a problem hiding this comment.
外から変更できるようにした方が使いやすいので、引数で挙動変えられる（デフォルトは false）な方がいいと思いますー
|
@hirokikondo86 Singleセレクトの時は勝手に閉じたほうが良くない？ |
|
@noronaoki |
オプショナルなのね。そしたら実装する人が選べるからいいか。 |
修正しました🙇♂️ |
|
シングルのSelectを使用していた |
|
@hirokikondo86 LGTM |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref
close voyagegroup/fluct_XDC#124
やったこと
closeMenuOnSelect={false}を追加して選択時に閉じないように修正スクショ
Before
After