Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

デフォルトでMenuが閉じるように変更 #276

Merged
merged 2 commits into from
Mar 31, 2021
Merged

デフォルトでMenuが閉じるように変更 #276

merged 2 commits into from
Mar 31, 2021

Conversation

hirokikondo86
Copy link
Contributor

@hirokikondo86 hirokikondo86 commented Mar 31, 2021 •
edited

概要

元が閉じる設計だったこともあり、closeMenuOnSelctが 指定されていなかったら = デフォルト = 今まで通りな設計に変更する。

やったこと

前回のissueでデフォルトでMenuは閉じない (closeMenuOnSelect=false) ように設定していたが、デフォルトで閉じる (closeMenuOnSelect=true) ように修正した。

@hirokikondo86 hirokikondo86 requested a review from a team as a code owner March 31, 2021 08:48
@hirokikondo86 hirokikondo86 self-assigned this Mar 31, 2021
ryokosuge
ryokosuge approved these changes Mar 31, 2021
View reviewed changes
Copy link
Contributor

@ryokosuge ryokosuge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hirokikondo86 hirokikondo86 merged commit bf79d0d into master Mar 31, 2021
@hirokikondo86 hirokikondo86 deleted the fix/close-menu-on-select branch March 31, 2021 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryokosuge ryokosuge ryokosuge approved these changes

@penicillin0 penicillin0 Awaiting requested review from penicillin0

Assignees

@hirokikondo86 hirokikondo86

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hirokikondo86 @ryokosuge