DeepCopy before processing ingress CRD

voyagermesh · Jan 29, 2018 · 5c54ad4 · 5c54ad4
1 parent 932c092
commit 5c54ad4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/pkg/ingress/controller.go b/pkg/ingress/controller.go
@@ -65,13 +65,13 @@ func NewController(
 	ingress *api.Ingress) Controller {
 	switch ingress.LBType() {
 	case api.LBTypeHostPort:
-		return NewHostPortController(ctx, kubeClient, crdClient, extClient, promClient, serviceLister, endpointsLister, opt, ingress.DeepCopy())
+		return NewHostPortController(ctx, kubeClient, crdClient, extClient, promClient, serviceLister, endpointsLister, opt, ingress)
 	case api.LBTypeNodePort:
-		return NewNodePortController(ctx, kubeClient, crdClient, extClient, promClient, serviceLister, endpointsLister, opt, ingress.DeepCopy())
+		return NewNodePortController(ctx, kubeClient, crdClient, extClient, promClient, serviceLister, endpointsLister, opt, ingress)
 	case api.LBTypeLoadBalancer:
-		return NewLoadBalancerController(ctx, kubeClient, crdClient, extClient, promClient, serviceLister, endpointsLister, opt, ingress.DeepCopy())
+		return NewLoadBalancerController(ctx, kubeClient, crdClient, extClient, promClient, serviceLister, endpointsLister, opt, ingress)
 	case api.LBTypeInternal:
-		return NewInternalController(ctx, kubeClient, crdClient, extClient, promClient, serviceLister, endpointsLister, opt, ingress.DeepCopy())
+		return NewInternalController(ctx, kubeClient, crdClient, extClient, promClient, serviceLister, endpointsLister, opt, ingress)
 	}
 	return nil
 }

diff --git a/pkg/operator/ingress_crds.go b/pkg/operator/ingress_crds.go
@@ -155,7 +155,7 @@ func (op *Operator) runEngressInjector(key string) error {
 		op.DeleteEngress(etx.Background(), engress)
 	} else {
 		glog.Infof("Sync/Add/Update for engress %s\n", key)
-		engress := obj.(*api.Ingress)
+		engress := obj.(*api.Ingress).DeepCopy()
 		engress.Migrate()
 
 		if engress.ShouldHandleIngress(op.Opt.IngressClass) {