Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use OwnerReference #285

Closed
tamalsaha opened this issue Jul 10, 2017 · 2 comments
Closed

Use OwnerReference #285

tamalsaha opened this issue Jul 10, 2017 · 2 comments
Milestone
5.0.0

Comments

@tamalsaha
Copy link
Contributor

tamalsaha commented Jul 10, 2017 •
edited

https://kubernetes.io/docs/concepts/workloads/controllers/garbage-collection/

https://github.com/kubernetes/kubernetes/blob/05d067d6bb626c622f0ceb5b16687c288d0d6c39/docs/proposals/garbage-collection.md#new-components

ownerReference.blockOwnerDeletion=true
@tamalsaha
Copy link
Contributor Author

https://groups.google.com/forum/#!msg/kubernetes-dev/juMOsdaCml0/FwVNJA9uBAAJ

@tamalsaha tamalsaha assigned tamalsaha and unassigned tamalsaha Aug 16, 2017
@tamalsaha tamalsaha added this to the 4.0.0 milestone Sep 5, 2017
@tamalsaha
Copy link
Contributor Author

CRDs are GC-ed from 1.8. prometheus-operator/prometheus-operator#12 . We need to see if we can remove our own GC code.

I don't think we can fully remove it since we manage Firewall rules ourselves.

@tamalsaha tamalsaha removed this from the 4.0.0 milestone Sep 5, 2017
tamalsaha added a commit that referenced this issue Sep 23, 2017
@tamalsaha
Add owner reference for Ingress
249907b 
Fixes #285
@tamalsaha tamalsaha mentioned this issue Sep 23, 2017
Merged
tamalsaha added a commit that referenced this issue Sep 23, 2017
@tamalsaha
Add owner reference for Ingress (#530)
d674edc 
Fixes #285
@tamalsaha tamalsaha added this to the 4.0.0 milestone Sep 23, 2017
tamalsaha added a commit that referenced this issue Dec 13, 2017
@tamalsaha
Add owner reference for Ingress (#530)
73b98e4 
Fixes #285
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
1 participant
@tamalsaha