Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly set port to binder #1049

Merged
merged 1 commit into from May 14, 2018
Merged

Correctly set port to binder #1049

merged 1 commit into from May 14, 2018

Conversation

tamalsaha
Copy link
Contributor

Fixes #1045

@tamalsaha tamalsaha requested a review from diptadas May 14, 2018 05:38
@codecov-io
Copy link

codecov-io commented May 14, 2018

Codecov Report

Merging #1049 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1049      +/-   ##
=========================================
- Coverage     3.8%    3.8%   -0.01%     
=========================================
  Files          52      52              
  Lines       18262   18264       +2     
=========================================
  Hits          695     695              
- Misses      17438   17440       +2     
  Partials      129     129
Impacted Files Coverage Δ
pkg/ingress/parser.go 3.69% <0%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed89892...38925ad. Read the comment docs.

@tamalsaha tamalsaha merged commit 0a38c22 into master May 14, 2018
@tamalsaha tamalsaha deleted the x7 branch May 14, 2018 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants