Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Backend Weight to be 0 #1396

Merged
merged 1 commit into from Jul 17, 2019
Merged

Allow Backend Weight to be 0 #1396

merged 1 commit into from Jul 17, 2019

Conversation

kfoozminus
Copy link
Contributor

  • Update parser/haproxy-templates
  • Update docs

Fixes #1387

@codecov-io
Copy link

codecov-io commented May 21, 2019

Codecov Report

Merging #1396 into master will increase coverage by 0.08%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1396      +/-   ##
=========================================
+ Coverage    3.66%   3.74%   +0.08%     
=========================================
  Files          35      35              
  Lines       19061   18640     -421     
=========================================
  Hits          698     698              
+ Misses      18236   17815     -421     
  Partials      127     127
Impacted Files Coverage Δ
pkg/haproxy/api/types.go 11.11% <ø> (ø) ⬆️
apis/voyager/v1beta1/annotations.go 29.79% <ø> (ø) ⬆️
pkg/ingress/parser.go 3.49% <0%> (-0.01%) ⬇️
apis/voyager/v1beta1/openapi_generated.go 0% <0%> (ø) ⬆️
pkg/ingress/controller.go 15.85% <0%> (+1.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19bd763...741dccb. Read the comment docs.

@tamalsaha tamalsaha merged commit b0c1f21 into master Jul 17, 2019
@tamalsaha tamalsaha deleted the weight0 branch July 17, 2019 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Backend Weight to be 0
3 participants