Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cert-manager docs #1417

Merged
merged 4 commits into from Jul 22, 2019
Merged

Add cert-manager docs #1417

merged 4 commits into from Jul 22, 2019

Conversation

kfoozminus
Copy link
Contributor

@kfoozminus kfoozminus commented Jul 17, 2019

  • cert-manger get-started
  • http01 challenge
  • dns01 challenge
    • aws-route53
    • azure-dns
    • google-dns
    • multiple provider together
  • Add images

@codecov-io
Copy link

codecov-io commented Jul 17, 2019

Codecov Report

Merging #1417 into master will increase coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1417      +/-   ##
=========================================
+ Coverage    3.68%   3.88%   +0.19%     
=========================================
  Files          35      35              
  Lines       19055   19716     +661     
=========================================
+ Hits          702     765      +63     
- Misses      18224   18821     +597     
- Partials      129     130       +1
Impacted Files Coverage Δ
pkg/ingress/controller.go 17.52% <0%> (-0.46%) ⬇️
pkg/ingress/nodeport.go 0% <0%> (ø) ⬆️
pkg/ingress/hostport.go 0% <0%> (ø) ⬆️
pkg/ingress/internal.go 0% <0%> (ø) ⬆️
pkg/ingress/loadbalancer.go 0% <0%> (ø) ⬆️
pkg/ingress/parser.go 4.45% <0%> (+0.96%) ⬆️
apis/voyager/v1beta1/annotations.go 31.41% <0%> (+1.78%) ⬆️
pkg/haproxy/api/types.go 14.58% <0%> (+3.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0952280...ec144b5. Read the comment docs.

@kfoozminus kfoozminus changed the title Add cert-manager docs [WIP] Add cert-manager docs Jul 17, 2019
@tamalsaha tamalsaha self-requested a review July 17, 2019 19:02
@kfoozminus kfoozminus force-pushed the cert-manager branch 3 times, most recently from 312aa65 to 40cb90f Compare July 18, 2019 03:50
@kfoozminus kfoozminus changed the title [WIP] Add cert-manager docs Add cert-manager docs Jul 18, 2019
@tamalsaha
Copy link
Contributor

tamalsaha commented Jul 21, 2019

Describe that certificate and wait until you see `Certificate issued successfully` when you describe the certificate.

```console
kubectl describe certificates.certmanager.k8s.io quickstart-kiteci-tls
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does Voyager automatically mount this ssl cert?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cert-manager updates the tls-secret mentioned in Ingress.

@tamalsaha tamalsaha merged commit 5f4cb23 into master Jul 22, 2019
@tamalsaha tamalsaha deleted the cert-manager branch July 22, 2019 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants